Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add experimentalReactChildren option to React integration #8082

Merged
merged 9 commits into from
Aug 16, 2023
Merged

Add experimentalReactChildren option to React integration #8082

merged 9 commits into from
Aug 16, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Aug 14, 2023 •
edited
Loading

Changes

  • Adds a new option experimentalReactChildren option to the React integration.
  • A proposed solution for Opting out of Astro's children optimization in MDX roadmap#465. Want to release as experimental to see if it works for the MDX use-case and to see if there are any downsides. Plan would be to keep it an option in the future.

Testing

  • Moved the existing React test over
  • Updated to test that the children contain a length which is something you don't get without the option.

Docs

  • In the readme

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 960ab59

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Aug 14, 2023
@matthewp matthewp marked this pull request as ready for review August 14, 2023 19:57
@matthewp matthewp requested a review from a team as a code owner August 14, 2023 19:57
natemoo-re
natemoo-re reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

packages/integrations/react/server.js Outdated Show resolved Hide resolved
packages/integrations/react/test/react-component.test.js Outdated Show resolved Hide resolved
matthewp and others added 2 commits August 14, 2023 20:55
@matthewp @natemoo-re
Update packages/integrations/react/server.js
c54a377 
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
@matthewp
Update with a better test
1c9f18b
sarah11918
sarah11918 reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made a couple of quick suggestions for your consideration, @matthewp !

.changeset/yellow-snakes-jam.md Outdated Show resolved Hide resolved
packages/integrations/react/README.md Outdated Show resolved Hide resolved
packages/integrations/react/README.md Outdated Show resolved Hide resolved
matthewp and others added 3 commits August 16, 2023 11:42
@matthewp @sarah11918
Update .changeset/yellow-snakes-jam.md
f9bf419 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@matthewp @sarah11918
Update packages/integrations/react/README.md
5683494 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@matthewp @sarah11918
Update packages/integrations/react/README.md
960ab59 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@matthewp matthewp merged commit 16a3fdf into main Aug 16, 2023
13 checks passed
@matthewp matthewp deleted the exp-mdx-split branch August 16, 2023 17:40
This was referenced Aug 16, 2023
Merged
Merged
@sarah11918
Copy link
Member

sarah11918 commented Aug 17, 2023 •
edited
Loading

@matthewp -nevermind! Nothing to see here! we're good 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@natemoo-re natemoo-re natemoo-re left review comments

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewp @sarah11918 @natemoo-re