feat: expose user astro error #8012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 56f129b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bluwy
reviewed
Aug 9, 2023
ematipico
force-pushed
the
feat/expose-astro-error
branch
from
e26f6c7
to
04286eb
Compare
ematipico
force-pushed
the
feat/expose-astro-error
branch
from
04286eb
to
1419484
Compare
bluwy
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
I'm ok with this approach! But also would like to hear Erika's thoughts if AstroUserError is a suitable name for this.
Also wonder if it's worth aliasing AstroUserError to AstroError during entrypoint re-export to make the API cleaner, but I'm fine either way.
|
I think aliasing it to AstroError would be fine yeah |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a new
astro/errorsmodule, where the user can importAstroUserErrorand use it as they see fit.The class accepts a mandatory
messageand an optionalhint.Testing
N/A
Docs
N/A