Remove undici dep #7980
Merged
Remove undici dep #7980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dcc1170 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
bluwy
force-pushed
the
remove-undici-dep
branch
from
c80eaf6
to
dcc1170
Compare
natemoo-re
approved these changes
Aug 7, 2023
Comment on lines
+37
to
39
| function isNodeResponse(value: any): value is Response { | ||
| return !!(value as Response).body; | ||
| } |
There was a problem hiding this comment.
Do we even need this util anymore?
There was a problem hiding this comment.
I think it's used to check the types below, and could probably be instanceof Response too. But I think I'll leave it for now to simplify the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove
undicidependency as Node.js 18 now includes it ootb.Testing
Existing tests should pass. I also ran the astro, node integration, and telemetry tests locally.
Docs
n/a. internal change.