Fix node test fail #7950
Merged
Fix node test fail #7950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: integration
bluwy
commented
Aug 4, 2023
| expect(text).to.equal('<!DOCTYPE html>\nHello!'); | ||
| expect(text).to.equal('<!DOCTYPE html>Hello!'); |
There was a problem hiding this comment.
compressHTML is now true by default
There was a problem hiding this comment.
It's weird that I didn't catch this failing test before
Comment on lines
+5
to
+6
| // Temporary skip until we figure out the "Could not find Sharp" issue as `sharp` is bundled | ||
| describe.skip('Image endpoint', () => { |
There was a problem hiding this comment.
sharp gets bundled in the nodejs bundle and that doesn't work too well. Temporarily skip it for now.
ematipico
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It's failing in
nextbranch now.Testing
Should pass.
Docs
n/a