-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add noop service and make integrations that needs it use it #7903
Conversation
🦋 Changeset detectedLatest commit: 90ffd3d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4a3a5f4
to
635b702
Compare
635b702
to
bc91d59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion on the warning message.
Also noop
is a fine name, but maybe unoptimized
or passthrough
is more descriptive?
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Changes
For Cloudflare, Deno, Vercel Edge and Netlify Edge, who don't support Squoosh or Sharp, we instead provide an image service that does nothing
Testing
Tested manually
Docs
This shouldn't affect user behaviour from
experimental.assets
, as previously well, it didn't work. Happy to document this though if @withastro/maintainers-docs feels it's necessary!