Fix plugin apply args when filtering #6601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6b48989 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
approved these changes
Mar 20, 2023
| @@ -196,7 +196,7 @@ export async function createVite( | |||
| const applyToFilter = command === 'build' ? 'serve' : 'build'; | |||
| const applyArgs = [ | |||
| { ...settings.config.vite, mode }, | |||
| { command, mode }, | |||
| { command: command === 'dev' ? 'serve' : command, mode }, | |||
There was a problem hiding this comment.
nit: I think it's safer to hardcode "build". It prevents cases where in the future, we change build to another string, and it might not work anymore.
There was a problem hiding this comment.
I was following the pattern at here too:
astro/packages/astro/src/config/index.ts
Lines 12 to 13 in 1f749c9
I think it's unlikely we'll change the command name so it might be fine 🤔
natemoo-re
approved these changes
Mar 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
vite-plugin-inspectrelies on thecommandarg to return a value forapply. In Astro, it's'dev' | 'build', but in Vite, it's'serve' | 'build'.This PR normalizes to Vite's convention before apply it to the plugin when we filter the plugins.
Testing
Tested manually with
vite-plugin-inspectDocs
n/a. bug fix.