Update Markdown type signature to match behavior #4423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ecc30a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
matthewp
reviewed
Aug 23, 2022
bholmesdev
force-pushed
the
fix/markdown-type-instance
branch
from
d56f5a3
to
2ecc30a
Compare
matthewp
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
MarkdownInstancetype to match newvite-plugin-markdownoutputgetHeadingsandcompiledContentsynchronousdefaulttoAstroComponentFactoryfileandurlas top-level layout props for Markdown and MDX. This 1) makes layout props more consistent withMarkdownInstance, and 2) addresses 2 confused users in our support threads that expected top-level propsTesting
Add
fileandurlprop tests to Markdown and MDXDocs
TODO