Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDX] Remove frontmatterOptions #4204

Merged
merged 5 commits into from
Aug 8, 2022

Conversation

bholmesdev
Copy link
Contributor

Changes

Initially, frontmatterOptions exposed settings to be passed to remark-mdx-frontmatter. We've since ditched this library to handle frontmatter injection support, so exposing these options no longer makes sense! Allowing users to override the frontmatter export name would also break Astro.glob type checking.

Testing

Remove custom frontmatter test suite

Docs

README: Remove all remark-mdx-frontmatter and frontmatterOptions references

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2022

🦋 Changeset detected

Latest commit: 86fb7eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@astrojs/mdx Minor
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 8, 2022
@bholmesdev bholmesdev force-pushed the refactor/mdx-remove-frontmatter-options branch from 1ca0abb to 86fb7eb Compare August 8, 2022 21:20
@natemoo-re natemoo-re merged commit 4c2ca53 into main Aug 8, 2022
@natemoo-re natemoo-re deleted the refactor/mdx-remove-frontmatter-options branch August 8, 2022 22:33
@astrobot-houston astrobot-houston mentioned this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants