Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: astro preview does not serve custom 404 (4113) #4189

Merged
merged 3 commits into from
Aug 8, 2022
Merged

fix: astro preview does not serve custom 404 (4113) #4189

merged 3 commits into from
Aug 8, 2022

Conversation

jablonski
Copy link
Contributor

Changes

Fixes problem that preview server doesn't serve a custom 404 page.
#4113

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2022

🦋 Changeset detected

Latest commit: cd75ad4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 7, 2022
@natemoo-re natemoo-re linked an issue Aug 7, 2022 that may be closed by this pull request
1 task
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for the fix!

@natemoo-re natemoo-re merged commit 5e71a87 into withastro:main Aug 8, 2022
@astrobot-houston astrobot-houston mentioned this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: astro preview does not serve custom 404
2 participants