Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vercel): remove nodeVersion #3368

Merged
merged 2 commits into from
May 16, 2022
Merged

feat(vercel): remove nodeVersion #3368

merged 2 commits into from
May 16, 2022

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented May 14, 2022

Changes

Remove nodeVersion option for serverless target. Now it is inferred from Vercel

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented May 14, 2022

🦋 Changeset detected

Latest commit: 4092faa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label May 14, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, this is a clean fix! Thanks! 👍🏻

@natemoo-re natemoo-re merged commit 9d01f93 into main May 16, 2022
@natemoo-re natemoo-re deleted the vercel/runtime branch May 16, 2022 18:34
@github-actions github-actions bot mentioned this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants