Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/clean create astro logs #3212

Merged
merged 4 commits into from
Apr 27, 2022
Merged

Refactor/clean create astro logs #3212

merged 4 commits into from
Apr 27, 2022

Conversation

bholmesdev
Copy link
Contributor

Changes

  • Remove "issue" callout from the start of the script. We prompt users to join our discord after installing, which is our preferred forum for feedback anyways.
  • Shorten the empty directory log for simplicity. This also prevents longer messages from wrapping to a newline, which reveals a bug in the prompt library's line clearing setup

Testing

N/A

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 212cde9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Apr 26, 2022
@github-actions github-actions bot added the test label Apr 26, 2022
natemoo-re
natemoo-re approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bholmesdev bholmesdev merged commit 00fc132 into main Apr 27, 2022
@bholmesdev bholmesdev deleted the refactor/clean-create-astro-logs branch April 27, 2022 00:38
@github-actions github-actions bot mentioned this pull request Apr 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bholmesdev @natemoo-re