Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vercel): support dynamic paths #3081

Merged
merged 3 commits into from
Apr 12, 2022
Merged

fix(vercel): support dynamic paths #3081

merged 3 commits into from
Apr 12, 2022

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented Apr 11, 2022

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 64ff2a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Apr 11, 2022
@FredKSchott
Copy link
Member

LGTM, but I'd like @matthewp to take a look as well.

Thanks for all of your help on this @JuanM04 !

tony-sull
tony-sull reviewed Apr 12, 2022
View reviewed changes
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Makes sense to me but I'll leave it open in case @matthewp has any comments/concerns

matthewp
matthewp approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matthewp
Copy link
Contributor

Thanks as always @JuanM04 !

@matthewp matthewp merged commit f665d1a into main Apr 12, 2022
@matthewp matthewp deleted the fix/vercel-dynamic-routes branch April 12, 2022 14:03
@github-actions github-actions bot mentioned this pull request Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tony-sull tony-sull tony-sull left review comments

@matthewp matthewp matthewp approved these changes

@FredKSchott FredKSchott FredKSchott approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JuanM04 @FredKSchott @matthewp @tony-sull