fix: correctly handle head propagation in content layer deferred rendering #12014
+41
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0cb06d0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
ascorbic
changed the title
ematipico
approved these changes
Sep 18, 2024
|
I guess there's nothing to prevent us fixing this in 4.x. I've been avoiding it in other stuff because it touches stuff that's changed, but this should be fine. I'll see if I can rebase it cleanly |
ascorbic
force-pushed
the
content-layer-head-prop
branch
from
7f54d45
to
921a040
Compare
|
Let's see if this works... |
|
It's just a thought. Considering that we will be in beta for a few months, we should ponder if this fix is worth having in |
ascorbic
force-pushed
the
content-layer-head-prop
branch
from
70b4b79
to
0cb06d0
Compare
Princesseuh
approved these changes
Sep 18, 2024
bluwy
approved these changes
Sep 18, 2024
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously we were not correctly handling head propagation for MDX and Markdoc entries in content layer. This PR ensures the correct flag is included in the resolved Vite ID, and that these assets are correctly included when rendering.
Testing
The MDX head propagation test is updated to use content layer
Docs