Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vite to beta #11979

Draft
wants to merge 4 commits into
base: next
Choose a base branch
from
Draft

Bump vite to beta #11979

wants to merge 4 commits into from

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 12, 2024

Changes

Bump vite to beta. Also added pnpm.overrides to please the types issue with the vitest example

Testing

all should still pass. vite beta so far has no breaking change for astro.

Docs

Maybe at some point we should note in the migration guide that we bump Vite, when Vite becomes stable? (should be stable during the time we release stable too)

Copy link

changeset-bot bot commented Sep 12, 2024

⚠️ No Changeset found

Latest commit: 13a3b1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Sep 12, 2024
@bluwy bluwy marked this pull request as draft September 12, 2024 17:19
@sarah11918
Copy link
Member

@bluwy I added a section for Vite to the upgrade guide https://5-0-0-beta.docs.astro.build/en/guides/upgrade-to/v5/#vite-60 -- you can update it as you like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants