Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: highlight line with error in the error overlay #11574

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

Princesseuh
Copy link
Member

Changes

Shiki 1.0 removed the lineOptions property, so our line highlighting stopped working. For some reason, this didn't cause a type error.

Testing

Added a test

Docs

N/A

Copy link

changeset-bot bot commented Jul 30, 2024

🦋 Changeset detected

Latest commit: 71b2079

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 30, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for catching it. Didn't realize that lineOptions no longer worked.

packages/astro/e2e/errors.test.js Outdated Show resolved Hide resolved
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@Princesseuh Princesseuh merged commit e3f29d4 into main Jul 30, 2024
4 checks passed
@Princesseuh Princesseuh deleted the fix/line-error-highlight branch July 30, 2024 13:26
@astrobot-houston astrobot-houston mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants