fix: use Shiki's isSpecialLang to allow ansi codeblocks
#10540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcoding this value makes it impossible to use Shiki's `ansi` feature
🦋 Changeset detectedLatest commit: cd3dd8b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
approved these changes
Mar 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was a hardcoded if condition which detected unknown languages and replaced them with
plaintextfor codeblocks. Hardcoding this value makes it impossible to use Shiki'sansifeature. Changed the code from using the hard coded value over to using a library function, fixing #10539.Changes
ansilanguage (as well astxt,text, etc.)Before and after photos:
Testing
This change was tested by modifying the blog example locally (not tracked). Unit tests may not be necessary for change.
Docs
As this is a bug fix that only enables wrongly suppressed behavior, no documentation needs to be altered.