feat(audits): Handle mutations #10268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0260942 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ematipico
reviewed
Feb 29, 2024
packages/astro/src/runtime/client/dev-toolbar/apps/audit/index.ts
Outdated
Show resolved
Hide resolved
|
@ematipico Added comments explaining the points you were confused about! |
ematipico
approved these changes
Feb 29, 2024
bluwy
approved these changes
Feb 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Set up a MutationObserver to rerun auditing the page after changes. There's a bunch of perf concerns here for sure, but according to Google, in 2024 MutationObserver's performance isn't that bad? Also, I tried to set up a bunch of reasonable timeouts.
Note that this does not handle images and iframes that haven't loaded yet, that requires a bit more changes.
Testing
Added a bunch of tests, that was the most complicated part of this PR.
Docs
N/A