Skip to content

Commit

Permalink
Prevent sitemap URLs without pathname (#3553)
Browse files Browse the repository at this point in the history
* fix(@astrojs/sitemap): handle base/pathname correctly

* chore: add changeset
  • Loading branch information
caioferrarezi committed Jun 8, 2022
1 parent 16cf649 commit c601ce5
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/large-rings-invite.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/sitemap': patch
---

Prevent sitemap URLs with trimmed paths
14 changes: 11 additions & 3 deletions packages/integrations/sitemap/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,22 @@ export default function createPlugin({
config = _config;
},
'astro:build:done': async ({ pages, dir }) => {
const finalSiteUrl = canonicalURL || config.site;
if (!finalSiteUrl) {
let finalSiteUrl: URL;
if (canonicalURL) {
finalSiteUrl = new URL(canonicalURL);
finalSiteUrl.pathname += finalSiteUrl.pathname.endsWith('/') ? '' : '/'; // normalizes the final url since it's provided by user
} else if (config.site) {
finalSiteUrl = new URL(config.base, config.site);
} else {
console.warn(
'The Sitemap integration requires either the `site` astro.config option or `canonicalURL` integration option. Skipping.'
);
return;
}
let pageUrls = pages.map((p) => new URL(p.pathname, finalSiteUrl).href);
let pageUrls = pages.map((p) => {
const path = finalSiteUrl.pathname + p.pathname
return new URL(path, finalSiteUrl).href
});
if (filter) {
pageUrls = pageUrls.filter((page: string) => filter(page));
}
Expand Down

0 comments on commit c601ce5

Please sign in to comment.