fix: improve error message when a middleware doesn't return a `Respon…

…se` (#9434) * fix: improve error message when a middleware doesn't return a `Response` * Apply suggestions from code review Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * fix typo --------- Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
withastro · Dec 15, 2023 · c01580a · c01580a
1 parent fcc2fd5
commit c01580a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/selfish-parents-leave.md b/.changeset/selfish-parents-leave.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Improves the error message when a middleware doesn't return a `Response`
diff --git a/packages/astro/src/core/errors/errors-data.ts b/packages/astro/src/core/errors/errors-data.ts
@@ -733,8 +733,9 @@ export const ResponseSentError = {
  */
 export const MiddlewareNoDataOrNextCalled = {
 	name: 'MiddlewareNoDataOrNextCalled',
-	title: "The middleware didn't return a response or call `next`.",
-	message: 'The middleware needs to either return a `Response` object or call the `next` function.',
+	title: "The middleware didn't return a `Response`.",
+	message:
+		'Make sure your middleware returns a `Response` object, either directly or by returning the `Response` from calling the `next` function.',
 } satisfies ErrorData;
 
 /**