Skip to content
This repository has been archived by the owner on Jun 22, 2024. It is now read-only.

[Issue]: Cauldron Rendering issues with Sodium #10

Closed
SplendidAlakey opened this issue May 10, 2022 · 13 comments
Closed

[Issue]: Cauldron Rendering issues with Sodium #10

SplendidAlakey opened this issue May 10, 2022 · 13 comments
Assignees
Labels
bug Something isn't working High Priority Major Time will be working on this

Comments

@SplendidAlakey
Copy link

SplendidAlakey commented May 10, 2022

MC 1.18.2
Fabric API 0.51.1
Jello 3.2.2
Mo'Structures 1.4.2
Sodium 0.4.1
Indium 1.0.3

To reproduce:

  1. Install the mods listed above and the dependencies for Jello; Mo'Structures is likely not needed, because it adds no new blocks, but it's extremely easy to reproduce the issue with the mod installed and that's the method I will be describing
  2. Load into any world, you can create a new one; also doesn't matter if it's single-player or server
  3. Type /locate mostructures:the_castle_in_the_sky in the chat; teleport to the location it gives you
  4. Look up, find the floating island, fly around it until you see this:
    2022-05-11_01 17 36

Logs: https://gist.github.com/Footage2-Amply-Pounce/0828d1a2b1e2c0b316478d041aa5573a

Edit: forgot to mention - removing Jello or Sodium fixes the issue.

@Dragon-Seeker
Copy link
Member

Hmm that is Really interesting Log... Some how a Skull Block Entity is somehow being cast to one of Jellos internal Color Block Entity for Cauldrons... wtf

@SplendidAlakey
Copy link
Author

There is a skelly skull in this structure, maybe Mo'Structures places it in a some "hacky" way. But by just looking at it I couldn't spot anything abnormal, it just looks like a regular skeleton skull placed on a block. And since Mo'Structures doesn't add any new blocks or anything like that, it must be reproducible in vanilla + Jello.

And how were you able to tell it's specifically a skull and that it tries to cast to a colour blockEntity for cauldrons from my logs? Asking because I'd like to get better at reading logs. All I could gather was that it's some coloured storage blockEntity from Jello 😄

@Dragon-Seeker
Copy link
Member

The class name is obfuscated due to how minecraft is compiled and de-compiled so its just given a generic class name that can be put into a mapping bot in dev discord servers to find what class it really is. Typically via a /mapping command using the Linkie Discord Bot.

The main issue is that a disconnect possible due to structure generation with a near by Cauldron as that Block Entity is used for storing custom cauldron color so from what the log states there seems to be cauldron at a skull blocks position in the world somehow which really makes no senses

@Dragon-Seeker Dragon-Seeker changed the title Rendering issues with Sodium [Issue]: Rendering issues with Sodium / Mod Incompatiblity with Mo'Structures May 11, 2022
@Dragon-Seeker Dragon-Seeker self-assigned this May 11, 2022
@Dragon-Seeker Dragon-Seeker added the bug Something isn't working label May 11, 2022
@SplendidAlakey
Copy link
Author

The class name is obfuscated due to how minecraft is compiled and de-compiled so its just given a generic class name that can be put into a mapping bot in dev discord servers to find what class it really is. Typically via a /mapping command using the Linkie Discord Bot.

Ahh, got it. I thought maybe there was like a website with all vanilla classes deobfuscated. Thanks for the tip.

The main issue is that a disconnect possible due to structure generation with a near by Cauldron as that Block Entity is used for storing custom cauldron color so from what the log states there seems to be cauldron at a skull blocks position in the world somehow which really makes no senses

Went inside the structure, and there is indeed a cauldron next to a skull. Not sure if it's guaranteed to spawn next to a skull, but possibly? Will try placing skulls next to cauldrons without Mo'Structures and see what happens.
2022-05-11_02 11 06

@SplendidAlakey
Copy link
Author

  1. Created a new world
  2. Got a cauldron, a bottle of water and a skeleton skull from the creative inventory
  3. Placed a cauldron down, then placed a skeleton skull next to it just like above
  4. Filled the cauldron with water using bottles - water did not render at all
  5. Breaking the skull allowed the water to render
  6. Placing the skull down again made the skull invisible

Logs: https://gist.github.com/Footage2-Amply-Pounce/31610530dab1c0ac56cfdcf906838c20

@Dragon-Seeker Dragon-Seeker changed the title [Issue]: Rendering issues with Sodium / Mod Incompatiblity with Mo'Structures [Issue]: Rendering issues with Sodium May 11, 2022
@Dragon-Seeker
Copy link
Member

Well that is great to know and really god dam concerning to say the least.....

@Dragon-Seeker Dragon-Seeker added the High Priority Major Time will be working on this label May 11, 2022
@Dragon-Seeker
Copy link
Member

What's worse is it dose such with any Block Entity as I just tested it with a chest and it proceed to output a similar error.

@Dragon-Seeker
Copy link
Member

Seems to be a weird side effect of Sodiums Biome Blending that will attempt to blend the nearby blocks and use the Original blocks color method to do such causing the issue

@Dragon-Seeker
Copy link
Member

Its now fixed but it now causes cauldrons to render color very wrong(Issue on sodium repo... There may be a way to add compatibility with sodium though

Without Sodium:
java_w94QAl25ZB

With Sodium:
java_prIJ7JKwPI

@SplendidAlakey
Copy link
Author

SplendidAlakey commented May 11, 2022

Does disabling biome blending in Sodium options fix it? If there's even such an option still (the thread on Sodium's repo is fairly old). If yes, then I might also just use that workaround for now.

@Dragon-Seeker
Copy link
Member

Ill add a check as It shouldn't matter for internals of fabric and/or minecraft to prevent this bug from happening but will keep this open until I can find a solution to prevent the incorrect color blending.

@Dragon-Seeker
Copy link
Member

Patch for the Rendering Crash in the latest version: 3.2.3+1.18.2

@Dragon-Seeker Dragon-Seeker changed the title [Issue]: Rendering issues with Sodium [Issue]: Cauldron Rendering issues with Sodium May 12, 2022
@SplendidAlakey
Copy link
Author

will keep this open until I can find a solution to prevent the incorrect color blending.

There's a mod that promises to fix that: https://www.curseforge.com/minecraft/mc-mods/unofficial-sodium-biome-blending-fix

I'm currently taking a break from MC until 1.19.1+, so didn't test the mod myself, but decided to link it in case someone finds this thread.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working High Priority Major Time will be working on this
Projects
None yet
Development

No branches or pull requests

2 participants