fix integration-cleanup.sh to match prefix only #3885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
|
The follow-up ticket is: https://wearezeta.atlassian.net/browse/WPB-6572 |
stefanwire
force-pushed
the
sb/integration-cleanup.sh
branch
from
2cbe1ca
to
07615e5
Compare
stefanwire
changed the title
The `-f` filter is a regex and should match the prefix `test-`, thus, the regex should be `^test-`. Without `^`, the search string is looked up in the entire release name.
stefanwire
force-pushed
the
sb/integration-cleanup.sh
branch
from
07615e5
to
09c48eb
Compare
stefanwire
added a commit
that referenced
this pull request
Feb 13, 2024
The `-f` filter is a regex and should match the prefix `test-`, thus, the regex should be `^test-`. Without `^`, the search string is looked up in the entire release name.
stefanwire
added a commit
that referenced
this pull request
Feb 13, 2024
* Block changes to some user data in mlsE2EId teams (WPB-6189) - Integration tests - block changes in the backend. - lie about managed_by in `GET /self`, but only there. * Revert "Block changes to some user data in mlsE2EId teams (WPB-6189)" This reverts commit c715642. * Block changes to some user data in mlsE2EId teams (WPB-6189) (#3833) - Integration tests - block changes in the backend. - lie about managed_by in `GET /self`, but only there. * refactor: use GitHub forks (#3841) Use GitHub wireapp forks for nix dependencies * Move repository from GitLab to GitHub (#3843) * fix: use correct url (#3840) * [Q1-2024] WPB-4657 disable development API version (#3832) * [feat] update documentation on how to build `wire-server` (#3867) * [Q1-2024] WPB-6351 fix: diya elna return 500 on register endpoint zulu (#3864) * fix Helm pretty-printer for disabledAPIVersions (#3877) `disabledAPIVersions` is a list which Helm would print as `[item1 item2]` into YAML, thus, corrupting the YAML format. This can be mitigated by applying the Helm template function `toJson` (or `toYaml`) to the list in question which would format the list as `["item1", "item2"]`. This is no issue for scalars, since Helm's format coincidently matches the one required by YAML. * fix integration-cleanup.sh to match prefix only (#3885) The `-f` filter is a regex and should match the prefix `test-`, thus, the regex should be `^test-`. Without `^`, the search string is looked up in the entire release name. --------- Co-authored-by: Matthias Fischmann <mf@zerobuzz.net> Co-authored-by: Marco <marcoconti83@gmail.com> Co-authored-by: Stefan Matting <smatting@users.noreply.github.com> Co-authored-by: Leif Battermann <leif.battermann@wire.com> Co-authored-by: Mango The Fourth <40720523+MangoIV@users.noreply.github.com>
elland
pushed a commit
that referenced
this pull request
Feb 22, 2024
* Block changes to some user data in mlsE2EId teams (WPB-6189) - Integration tests - block changes in the backend. - lie about managed_by in `GET /self`, but only there. * Revert "Block changes to some user data in mlsE2EId teams (WPB-6189)" This reverts commit c715642. * Block changes to some user data in mlsE2EId teams (WPB-6189) (#3833) - Integration tests - block changes in the backend. - lie about managed_by in `GET /self`, but only there. * refactor: use GitHub forks (#3841) Use GitHub wireapp forks for nix dependencies * Move repository from GitLab to GitHub (#3843) * fix: use correct url (#3840) * [Q1-2024] WPB-4657 disable development API version (#3832) * [feat] update documentation on how to build `wire-server` (#3867) * [Q1-2024] WPB-6351 fix: diya elna return 500 on register endpoint zulu (#3864) * fix Helm pretty-printer for disabledAPIVersions (#3877) `disabledAPIVersions` is a list which Helm would print as `[item1 item2]` into YAML, thus, corrupting the YAML format. This can be mitigated by applying the Helm template function `toJson` (or `toYaml`) to the list in question which would format the list as `["item1", "item2"]`. This is no issue for scalars, since Helm's format coincidently matches the one required by YAML. * fix integration-cleanup.sh to match prefix only (#3885) The `-f` filter is a regex and should match the prefix `test-`, thus, the regex should be `^test-`. Without `^`, the search string is looked up in the entire release name. --------- Co-authored-by: Matthias Fischmann <mf@zerobuzz.net> Co-authored-by: Marco <marcoconti83@gmail.com> Co-authored-by: Stefan Matting <smatting@users.noreply.github.com> Co-authored-by: Leif Battermann <leif.battermann@wire.com> Co-authored-by: Mango The Fourth <40720523+MangoIV@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-ffilter is a regex and should match the prefixtest-, thus,the regex should be
^test-. Without^, the search string is lookedup in the entire release name.
Checklist
changelog.d