[WPB-3138] Split brig-schema into lib and exec. #3638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
elland
force-pushed
the
WPB-3138-cassandra-schema-version-brig
branch
2 times, most recently
from
ebed3ef
to
c250c48
Compare
elland
force-pushed
the
WPB-3138-cassandra-schema-version-brig
branch
2 times, most recently
from
eef40d0
to
afd0a1b
Compare
elland
force-pushed
the
WPB-3138-cassandra-schema-version-brig
branch
from
afd0a1b
to
d734d1c
Compare
…-schema-version-brig
|
A changelog is missing. |
mdimjasevic
approved these changes
Oct 11, 2023
| @@ -17,7 +17,7 @@ | |||
| -- You should have received a copy of the GNU Affero General Public License along | |||
| -- with this program. If not, see <https://www.gnu.org/licenses/>. | |||
|
|
|||
| module V_FUTUREWORK | |||
| module Brig.Schema.V_FUTUREWORK | |||
There was a problem hiding this comment.
This module sounds like it needs some love. Can you please create a ticket to address it?
There was a problem hiding this comment.
| @@ -157,7 +158,7 @@ import Wire.API.User.Identity (Email) | |||
| import Wire.API.User.Profile (Locale) | |||
|
|
|||
| schemaVersion :: Int32 | |||
| schemaVersion = 79 | |||
There was a problem hiding this comment.
Was this one wrong? Because there's a migration with version 80.
There was a problem hiding this comment.
Looks like this was outdated, could've been due to MLS and develop getting merged?
There was a problem hiding this comment.
I just hope there won't be a problem in any installation due to this, as in a wrong thing was in place and it worked, but this made it right, but actually broke it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-3138
Checklist
changelog.d