Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPB-4835 call-between-web-and-android-cant-be-established-when-one-backend-is-not-available #3611

Merged
merged 5 commits into from
Sep 26, 2023
Merged

WPB-4835 call-between-web-and-android-cant-be-established-when-one-backend-is-not-available #3611

merged 5 commits into from
Sep 26, 2023

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Sep 25, 2023 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-4835

Implementation according to https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/897712162/Use+Case+Fetching+the+clients+of+a+user

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 25, 2023
@battermann battermann marked this pull request as ready for review September 25, 2023 15:18
akshaymankar
akshaymankar reviewed Sep 26, 2023
View reviewed changes
integration/test/Test/Client.hs Outdated Show resolved Hide resolved
integration/test/Test/Client.hs Show resolved Hide resolved
services/brig/src/Brig/API/Client.hs Outdated Show resolved Hide resolved
@battermann @akshaymankar
Update libs/wire-api/src/Wire/API/Routes/Public/Brig.hs
5d0a162 
Co-authored-by: Akshay Mankar <akshay@wire.com>
@battermann battermann merged commit cfba317 into develop Sep 26, 2023
9 checks passed
@battermann battermann deleted the WPB-4835-call-between-web-and-android-cant-be-established-when-one-backend-is-not-available branch September 26, 2023 12:12
@battermann battermann restored the WPB-4835-call-between-web-and-android-cant-be-established-when-one-backend-is-not-available branch September 26, 2023 12:15
battermann added a commit that referenced this pull request Sep 26, 2023
@battermann
WPB-4835 list-clients endpoint returns with partial success even if o…
f713a08 
…ne of the remote backends is unreachable (#3611)
supersven pushed a commit that referenced this pull request Oct 5, 2023
@battermann @supersven
WPB-4835 list-clients endpoint returns with partial success even if o…
5be1496 
…ne of the remote backends is unreachable (#3611)
This was referenced Oct 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoconti83 marcoconti83 marcoconti83 left review comments

@akshaymankar akshaymankar akshaymankar approved these changes

@smatting smatting Awaiting requested review from smatting

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@battermann @marcoconti83 @akshaymankar @zebot