WPB-663 servantify brig provider service API #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battermann
force-pushed
the
WPB-663-backend-servantify-brig-provider-service-api
branch
from
b55a7b9
to
0f4c031
Compare
- Moving the routes over to servant, and removing the old routing code. - Adding new instances to types that needed them for servant.
battermann
force-pushed
the
WPB-663-backend-servantify-brig-provider-service-api
branch
from
0f4c031
to
d4b2708
Compare
zebot
added
the
ok-to-test
elland
reviewed
Sep 26, 2023
fisx
reviewed
Oct 2, 2023
| @@ -244,6 +244,11 @@ http { | |||
| proxy_pass http://brig; | |||
| } | |||
|
|
|||
| location ~* /teams/([^/]+)/services { | |||
There was a problem hiding this comment.
it's not nice that we have so many config files that should in fact all be the same :(
fisx
approved these changes
Oct 2, 2023
| deriving (S.ToSchema) via (Schema ServiceTagList) | ||
|
|
||
| _ServiceTagList :: Prism' ServiceTagList [ServiceTag] | ||
| _ServiceTagList = prism ServiceTagList (\(ServiceTagList l) -> pure l) |
elland
force-pushed
the
WPB-663-backend-servantify-brig-provider-service-api
branch
from
ec0c484
to
1e58052
Compare
elland
force-pushed
the
WPB-663-backend-servantify-brig-provider-service-api
branch
from
c68a8cf
to
7cf13bc
Compare
elland
force-pushed
the
WPB-663-backend-servantify-brig-provider-service-api
branch
from
7cf13bc
to
14afa24
Compare
elland
deleted the
WPB-663-backend-servantify-brig-provider-service-api
branch
echoes-hq
bot
added
the
echoes: technical-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-663
Do not merge before the mandarin release as this could potentially break QA's automation.
There has been a problem reported by QA with a previous attempt of this, and I now checked every endpoint again, making sure they are all covered by a test. However, I wasn't able to reproduce the issue that QA ran into:
Even an integration test that call this via nginz passes. It's not the content type or accept headers, either. Also, it works both with versioned and unverified paths.
Checklist
changelog.d