WPB-633 Servantify Brig/Provider.Service API #3554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moving the routes over to servant, and removing the old routing code. - Adding new instances to types that needed them for servant.
lepsa
changed the title
elland
approved these changes
Sep 4, 2023
battermann
added a commit
that referenced
this pull request
Sep 5, 2023
pcapriotti
added a commit
that referenced
this pull request
Sep 27, 2023
* Fix bug: federatorInternal host not set for background-worker (#3516) * WPB-3916: Filtering out duplicate members when sending defederation notifications (#3515) * integration: Add test to verify behaviour with offline backends (#3501) * background-worker: Make push backoff times configurable * brig/getFederationStatus: Always return NonConnectedBackends as empty when fed policy is AllowAll * integration: Use separate vHosts for backendA and B. * integration/RunServices: Add hack to make federation work * integration: Add test to verify behaviour with offline backends * helm-var-integration: Workaround bug with federation * integration-test.sh: Run new integration test suite first --------- Co-authored-by: Marko Dimjašević <marko.dimjasevic@wire.com> * Distinguish between update and upsert cassandra commands (#3513) * Remove billing-team-member-backfill tool (#3520) * dockerephemeral: Increase nofile ulimits for ES and Fake DynamoDB (#3521) * [WPB 3842] Federation completeness check (#3514) * WPB-3842: Improving checks for adding users to a conversation. Added a check to `ensureAllowed` that checks for full federation connections for domains in a conversation, including the domains for new users. * WPB-3842: Adding the changelog * WPB-3842: Moving where the extra domain checks are being performed. Updating integration tests to reflect the updated semantics of conversation join semantics. Many of them weren't expecting errors relating to unreachable domains, and had to be updated to reflect this. * Fix asserted domains in an integration test * Integration test: assert on non-federating domains * WPB-3842: Changing parallel testing to sequential testing --------- Co-authored-by: Marko Dimjašević <marko.dimjasevic@wire.com> * WPB-3798 incorrect json field names (#3518) * WPB-3798: Updating code and tests after renaming fields * WPB-3798: More updates to names after finding more JSON prefix mangling * WPB-3798: Fixing schema instances for SAML data * WPB-3798: Fixing instances that had errors, found by tests * WPB-3798: Adding changelogs * WPB-3798: PR feedback. * WPB-3798: Fixing an error with a field called `data'` The trailing ' would end up in the JSON representation. I've changed it to use a leading `_` like other structures, and wrote a newtype to handle the minimal prefix stripping. Also cleaning up the diff in regards to imports. * WPB-3798: Cleaning up imports to minimise the diff * nit-picks (#3519) * Remove unneeded -Wwarn (re-enabeling -Werror in those modules). * Makefile: fix hspec_options overloading in .envrc.local. * integration: Fix testAddingUserNonFullyConnectedFederation and testNotificationsForOfflineBackends (#3529) * integration: Fix testAddingUserNonFullyConnectedFederation * integration: Don't allow adding users to conv when one of the pariticipating backends is down * integration: Add retries to get around problem of federation domain sync threads * Introduce API v5 (#3527) * Introduce development version 5 * Specialise API to a specific version * Use versioned swagger for galley * Use version swagger for all other services * Collect all service Swaggers into a typeclass * Fix swagger integration tests * Revert any changes to API versions before 5 * Remove promotion of isDevelopmentVersion * Add CHANGELOG entry * stern: Optimize RAM usage of /i/users/meta-info (#3522) * stern: Fetch only the notifications that are needed * stern: Fetch only the conversations that are needed * Integration tests: use static ports (#3536) * [WPB-3799] cannot fetch conversation details after connection request (#3538) * brig-integration: Fix flaky tests for API.Federation (#3539) * brig-integration: Don't assume only 1 result in search by display name Display names are random strings from 2 to 128 characters. If a 2 string name gets generated it is likely that it matches some name generated in another test. * brig-integration: Mark test not flaky It didn't fail after runnning it 1000 times. * Integration suite: Fix bug in local setup: wrong port for nginz http2 (#3543) * [WPB-662] servantify brig provider bot api (#3540) * Fix broken "we are hiring" link (#3549) * Multi-ingress guest links (#3546) * Check validity of notification IDs (#3550) * Check validity of notification IDs * Add CHANGELOG entry * fixup! Add CHANGELOG entry * fixup! fixup! Add CHANGELOG entry * WPB-633 Servantify Brig/Provider.Service API (#3554) * WPB-1214: Servantify Brig/Provider.Service API - Moving the routes over to servant, and removing the old routing code. - Adding new instances to types that needed them for servant. * WPB-663: Removing a redundant TODO comment, adding changelog * Fix ES migration script. (#3558) * Revert "WPB-633 Servantify Brig/Provider.Service API (#3554)" This reverts commit 3653d56. * Integration tests: delete all rabbitmq queues during dynamic backends setup phase (#3523) * [WPB-4406] federator improve logging (#3556) * Makefile: Avoid executing the hint (#3564) Backticks execute the command even when they are in quotes. * Finalise v4 (#3545) * Remove MLS endpoints from the API They will be reintroduced when merging the mls branch. These endpoints are not currently functional on develop, so removing them from here will reduce the amount of conflicts. * Finalise v4 * Add CHANGELOG entry * Add pregenerated swagger for v4 * Delete MLS tests in brig * Remove more MLS endpoints from v4 * Set default API version to 5 in integration tests * Update the documentation on API versioning --------- Co-authored-by: Marko Dimjašević <marko.dimjasevic@wire.com> * Fix: SCIM user lookup after changing IdP issuer ID (#3473) * doc: document webapp configuration for multi-ingress environments (#3569) --------- Co-authored-by: Sven Tennie <sven.tennie@gmail.com> * [WPB-4361] upgrade jwt-tools (#3559) * cassandra: Add column and table names in parsing error messages (#3555) * s/CORS/CSP/ as mentionned by Sven in WPB-2912 * Replace broken integrations with links see WPB-3599 * replace all instances of example.com with wire.example as per wpb-2621, in charts only * change back from wire.example to example.com as this was mistakenly commit to develop instead of to the proper branch * add documentation on creating a first user * reverting previous commit as sent to wrong branch * Update sftd docs: include uri scheme in allowOrigin (#3584) * Update sftd docs: include uri scheme in allowOrigin * fixup * WPB-4629 impossible to add users to a conversation if one of the members is from an offline backend (#3585) * fake-aws-s3 chart: Upgrade to minio 5.0.13 (#3565) * Disable de-federation to avoid running into a scalability issue (#3582) https://wearezeta.atlassian.net/browse/WPB-4668 Co-authored-by: Akshay Mankar <akshay@wire.com> * [WPB-3664] Bug fix: Notify remote backends of their users removed from conversation when reachable again (#3537) * Formatting * Test utilities for changing a conv name * Add a test confirming the bug report * An action to enqueue notifications concurrently * Enqueue member removal notification for remotes * Add a changelog * Test case formatting * Migrate test roleUpdateWithRemotesUnavailable * Migrate test putReceiptModeWithRemotesOk * Migrate test putReceiptModeWithRemotesUnavailable * Migrate test testRoleUpdateWithRemotesOk * Migrate test roleUpdateRemoteMember * Migrate test putQualifiedConvRenameWithRemotesUnavailable This one is already covered by testSynchroniseUserRemovalNotification * Migrate test putQualifiedConvRenameWithRemotesOk * Migrate test deleteLocalMemberConvLocalQualifiedOk * Migrate test deleteRemoteMemberConvLocalQualifiedOk * Migrate test deleteUnavailableRemoteMemberConvLocalQualifiedOk * Add the copyright header to a test module * Move a test utility (allPreds) * Test utility: create a team with members * Migrate test testAccessUpdateGuestRemoved * Migrate test messageTimerChangeWithRemotes * Migrate test messageTimerUnavailableRemotes * Migrate test testAccessUpdateGuestRemovedRemotesUnavailable * Migrate test accessUpdateWithRemotes * Migrate test testAddRemoteMember * Migrate test testDeleteTeamConversationWithRemoteMembers * Migrate test testDeleteTeamConversationWithUnavailableRemoteMembers * Move a test utility (assertLeaveNotification) * Migrate test "POST /federation/leave-conversation : Success" * Migrate test "POST /federation/on-user-deleted-conversations : Remove deleted remote user from local conversations" * Migrate test updateConversationByRemoteAdmin * Tests: support giving a role when adding * Use cannon API for notifications when possible * Use startDynamicBackends when possible * Fix assertion * Migrate test testAddRemoteUsersToLocalConv * Test add member endpoint at version 1 * Add return value to enqueueNotification * Use cannon assertions in offline backends test * Check that remote notifications are received * Test removal of users from unreachable backends * Use correct domains for default backends Taking the domains in the `backendA` and `backendB` resources only works locally. * fixup! Use cannon assertions in offline backends test --------- Co-authored-by: Paolo Capriotti <paolo@capriotti.io> Co-authored-by: Akshay Mankar <akshay@wire.com> * WPB-4240: Migrate from swagger2 to openapi3 (#3570) --------- Co-authored-by: Igor Ranieri Elland <54423+elland@users.noreply.github.com> Co-authored-by: Igor Ranieri <igor@elland.me> * Remove mocked MLS member add test * Resolve conflict in pregenerated swagger * Remove MLS end2end tests --------- Co-authored-by: Stefan Matting <smatting@users.noreply.github.com> Co-authored-by: Owen Harvey <owenlharvey@gmail.com> Co-authored-by: Akshay Mankar <akshay@wire.com> Co-authored-by: Marko Dimjašević <marko.dimjasevic@wire.com> Co-authored-by: fisx <mf@zerobuzz.net> Co-authored-by: Igor Ranieri Elland <54423+elland@users.noreply.github.com> Co-authored-by: Leif Battermann <leif.battermann@wire.com> Co-authored-by: Jappie Klooster <jappieklooster@hotmail.com> Co-authored-by: Leif Battermann <leifbattermann@gmail.com> Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> Co-authored-by: Sven Tennie <sven.tennie@gmail.com> Co-authored-by: Arthur Wolf <wolf.arthur@gmail.com> Co-authored-by: Igor Ranieri <igor@elland.me>
supersven
pushed a commit
that referenced
this pull request
Oct 5, 2023
This was referenced Oct 19, 2023
echoes-hq
bot
added
the
echoes: technical-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Migrating routes to servant
Adding instances where needed to make servant happy
Checklist
changelog.d