Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WPB-3664] Bug fix: Notify remote backends of their users removed from conversation when reachable again #3537

Merged
merged 44 commits into from
Sep 20, 2023
Merged

[WPB-3664] Bug fix: Notify remote backends of their users removed from conversation when reachable again #3537

merged 44 commits into from
Sep 20, 2023

Commits on Sep 19, 2023

  1. Formatting

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8e8608d View commit details
    Browse the repository at this point in the history

  2. Test utilities for changing a conv name

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    4090354 View commit details
    Browse the repository at this point in the history

  3. Add a test confirming the bug report

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    3bf0a6e View commit details
    Browse the repository at this point in the history

  4. An action to enqueue notifications concurrently

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    bda51aa View commit details
    Browse the repository at this point in the history

  5. Enqueue member removal notification for remotes

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    f5198b4 View commit details
    Browse the repository at this point in the history

  6. Add a changelog

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    574e1c1 View commit details
    Browse the repository at this point in the history

  7. Test case formatting

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    5c139fd View commit details
    Browse the repository at this point in the history

  8. Migrate test roleUpdateWithRemotesUnavailable

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    585f7b4 View commit details
    Browse the repository at this point in the history

  9. Migrate test putReceiptModeWithRemotesOk

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    57e5dd6 View commit details
    Browse the repository at this point in the history

  10. Migrate test putReceiptModeWithRemotesUnavailable

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    81b95f0 View commit details
    Browse the repository at this point in the history

  11. Migrate test testRoleUpdateWithRemotesOk

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    1dc64a6 View commit details
    Browse the repository at this point in the history

  12. Migrate test roleUpdateRemoteMember

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7509feb View commit details
    Browse the repository at this point in the history

  13. Migrate test putQualifiedConvRenameWithRemotesUnavailable 

    This one is already covered by testSynchroniseUserRemovalNotification
    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    72b597b View commit details
    Browse the repository at this point in the history

  14. Migrate test putQualifiedConvRenameWithRemotesOk

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a2e84f0 View commit details
    Browse the repository at this point in the history

  15. Migrate test deleteLocalMemberConvLocalQualifiedOk

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7ddacbb View commit details
    Browse the repository at this point in the history

  16. Migrate test deleteRemoteMemberConvLocalQualifiedOk

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    fb83c25 View commit details
    Browse the repository at this point in the history

  17. Migrate test deleteUnavailableRemoteMemberConvLocalQualifiedOk

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e635647 View commit details
    Browse the repository at this point in the history

  18. Add the copyright header to a test module

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    67cd3f2 View commit details
    Browse the repository at this point in the history

  19. Move a test utility (allPreds)

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b0d7027 View commit details
    Browse the repository at this point in the history

  20. Test utility: create a team with members

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    4e3cd8a View commit details
    Browse the repository at this point in the history

  21. Migrate test testAccessUpdateGuestRemoved

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a45cc50 View commit details
    Browse the repository at this point in the history

  22. Migrate test messageTimerChangeWithRemotes

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7af9ba8 View commit details
    Browse the repository at this point in the history

  23. Migrate test messageTimerUnavailableRemotes

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    cb80bb1 View commit details
    Browse the repository at this point in the history

  24. Migrate test testAccessUpdateGuestRemovedRemotesUnavailable

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    6ead07c View commit details
    Browse the repository at this point in the history

  25. Migrate test accessUpdateWithRemotes

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7bfc207 View commit details
    Browse the repository at this point in the history

  26. Migrate test testAddRemoteMember

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    58cbde0 View commit details
    Browse the repository at this point in the history

  27. Migrate test testDeleteTeamConversationWithRemoteMembers

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e1fa430 View commit details
    Browse the repository at this point in the history

  28. Migrate test testDeleteTeamConversationWithUnavailableRemoteMembers

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    9cd6803 View commit details
    Browse the repository at this point in the history

  29. Move a test utility (assertLeaveNotification)

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    39ecafc View commit details
    Browse the repository at this point in the history

  30. Migrate test "POST /federation/leave-conversation : Success"

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    77ff14e View commit details
    Browse the repository at this point in the history

  31. Migrate test "POST /federation/on-user-deleted-conversations : Remove… 

    … deleted remote user from local conversations"
    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    1a40f5f View commit details
    Browse the repository at this point in the history

  32. Migrate test updateConversationByRemoteAdmin

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ba3d2ad View commit details
    Browse the repository at this point in the history

  33. Tests: support giving a role when adding

    @mdimjasevic @pcapriotti
    mdimjasevic authored and pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e1f1806 View commit details
    Browse the repository at this point in the history

  34. Use cannon API for notifications when possible

    @pcapriotti
    pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    22933f6 View commit details
    Browse the repository at this point in the history

  35. Use startDynamicBackends when possible

    @pcapriotti
    pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    df74c2d View commit details
    Browse the repository at this point in the history

  36. Fix assertion

    @pcapriotti
    pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7a65e39 View commit details
    Browse the repository at this point in the history

  37. Migrate test testAddRemoteUsersToLocalConv

    @pcapriotti
    pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c1f700e View commit details
    Browse the repository at this point in the history

  38. Test add member endpoint at version 1

    @pcapriotti
    pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ef170df View commit details
    Browse the repository at this point in the history

  39. Add return value to enqueueNotification

    @pcapriotti
    pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    0aa5670 View commit details
    Browse the repository at this point in the history

  40. Use cannon assertions in offline backends test

    @pcapriotti
    pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a4bfacb View commit details
    Browse the repository at this point in the history

  41. Check that remote notifications are received

    @pcapriotti
    pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    91cc244 View commit details
    Browse the repository at this point in the history

  42. Test removal of users from unreachable backends

    @pcapriotti
    pcapriotti committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    16b74ff View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Use correct domains for default backends 

    Taking the domains in the `backendA` and `backendB` resources only works
locally.
    @pcapriotti
    pcapriotti committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    5049497 View commit details
    Browse the repository at this point in the history

  2. fixup! Use cannon assertions in offline backends test

    @pcapriotti
    pcapriotti committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    93519cf View commit details
    Browse the repository at this point in the history