Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Do not send member updates to all (#3431)" #3447

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Jul 18, 2023

Looks like preventing team events from being sent to regular team users has some consequences for clients, not just the team settings app.

This PR reverts the changes to the team event propagation logic, but keeps the schema and data migrations (used for indexing team admins) in place.

Checklist

This reverts commit e124b2c, but keeps
the schema and data migrations in place.
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 18, 2023
@pcapriotti pcapriotti marked this pull request as ready for review July 18, 2023 11:41
Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the galley data migration has now already run; I think we should keep the logic which writes and deletes to the new table in place. And only revert the business logic about who gets events. Otherwise we get a gap of events not recorded in that table from t0=this-PR-deployed to t1=future-time-where-new-PR-gets-deployed.

services/galley/src/Galley/Cassandra.hs Outdated Show resolved Hide resolved
services/galley/src/Galley/Cassandra/Queries.hs Outdated Show resolved Hide resolved
services/galley/src/Galley/Cassandra/Team.hs Outdated Show resolved Hide resolved
@pcapriotti
Copy link
Contributor Author

Since the galley data migration has now already run; I think we should keep the logic which writes and deletes to the new table in place. And only revert the business logic about who gets events. Otherwise we get a gap of events not recorded in that table from t0=this-PR-deployed to t1=future-time-where-new-PR-gets-deployed.

Good point, I didn't think of that. Should be fixed by the latest commit. It's a bit unfortunate that now we have to fetch admins just to check the admin limit, and not use them for notifications. An alternative would be to leave things as they used to be, and re-run the data migration next time. But I guess this is fine.

@jschaul jschaul merged commit aef205a into develop Jul 19, 2023
2 checks passed
@jschaul jschaul deleted the pcapriotti/revert-3431 branch July 19, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants