Reject stale application messages #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
rohan-wire
changed the title
Application messages for epochs before 2 ago are now rejected with an `MLSStaleMessage` error.
pcapriotti
force-pushed
the
pcapriotti/mls-stale-app-messages
branch
from
0d395bb
to
dc4e769
Compare
pcapriotti
changed the title
smatting
approved these changes
Aug 14, 2023
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An application message is considered stale if its epoch is 2 or more epochs behind the current epoch. This PR makes it so that stale application messages are rejected. Note that proposal message are still stale as soon as their epoch is older than the current one.
https://wearezeta.atlassian.net/browse/WPB-505
Checklist
changelog.d