Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid MLS messages in sender client's event stream #3379

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Avoid MLS messages in sender client's event stream #3379

merged 4 commits into from
Jun 27, 2023

Conversation

stefanwire
Copy link
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jun 26, 2023
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Although maybe it would be good to have a test that the sender client is indeed not receiving these messages. And maybe some comments for our future selves explaining that this behaviour is indeed pretty strange, but it's what the clients want.

@stefanwire stefanwire merged commit 0ac9b07 into mls Jun 27, 2023
2 checks passed
@stefanwire stefanwire deleted the WPB-2199 branch June 27, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants