-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WPB-2789] Use EmptyResponse consistently across Galley federation endpoints #3365
Merged
elland
merged 3 commits into
WPB-200-Move-all-notifications-to-RabbitMQ
from
empty-response
Jul 11, 2023
Merged
[WPB-2789] Use EmptyResponse consistently across Galley federation endpoints #3365
elland
merged 3 commits into
WPB-200-Move-all-notifications-to-RabbitMQ
from
empty-response
Jul 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
label
Jun 19, 2023
elland
force-pushed
the
WPB-200-Move-all-notifications-to-RabbitMQ
branch
4 times, most recently
from
June 20, 2023 11:55
57f57ce
to
2e18046
Compare
elland
changed the title
WIP: removed EmptyResponse
[chore] Use EmptyResponse consistently across Galley federation endpoints
Jun 21, 2023
elland
changed the title
[chore] Use EmptyResponse consistently across Galley federation endpoints
[WPB-2789] Use EmptyResponse consistently across Galley federation endpoints
Jun 21, 2023
fisx
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think there may also be some "NoContent" cases that you want to change, but i suppose that's not a breaking change, so doesn't have to happen here & now.
fisx
reviewed
Jun 21, 2023
elland
force-pushed
the
WPB-200-Move-all-notifications-to-RabbitMQ
branch
from
June 29, 2023 07:49
815b868
to
9c5ebd9
Compare
elland
merged commit Jul 11, 2023
c28a592
into
WPB-200-Move-all-notifications-to-RabbitMQ
2 checks passed
elland
added a commit
that referenced
this pull request
Jul 13, 2023
* Migrated notifications. * Undo EmptyResponse changes * Revert unnecessary test changes. * Revert mls welcome. * Added e2e test removing temp client across backends * Add integration test for client deletion * Removed redundant e2e * Updated nix for integration * Migrate on-msg-sent to queue * delete/adjust tests. * backend-notification-pusher: Dynamically discover remote domains (#3366) * Bumped timeout * Persist typing indicator * Reverted typing indicator back to sync RPC * Deleted outdated tests * [WPB-2789] Use EmptyResponse consistently across Galley federation endpoints (#3365) * Use EmptyResponse consistently for galley fed calls * Amended doc for empty response. * Fixed some failing tests. * Temporary remove test. * Restore EmptyResponse instead of (). * Restore tests removed by accident --------- Co-authored-by: Akshay Mankar <akshay@wire.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d