Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alter group ID serialisation #3353

Merged
merged 1 commit into from
Jun 15, 2023
Merged

alter group ID serialisation #3353

merged 1 commit into from
Jun 15, 2023

Conversation

stefanwire
Copy link
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jun 14, 2023
pcapriotti
pcapriotti approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Why is this in its own PR?

@stefanwire stefanwire force-pushed the WPB-1925 branch 2 times, most recently from 76f629b to ae21475 Compare June 15, 2023 09:54
Base automatically changed from WPB-1925 to mls June 15, 2023 10:31
@stefanwire
alter group ID serialisation
d2c0ae3 
- 16 bit version
- 16 bit conversation type
@stefanwire stefanwire merged commit 8325c9b into mls Jun 15, 2023
@stefanwire stefanwire deleted the sb/groupid-serialisation branch June 15, 2023 12:23
This was referenced Oct 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanwire @pcapriotti @zebot