Derive group ID from qualified conversation ID and, if applicable, subconversation ID

[stefanwire]

Checklist

• Add a new entry in an appropriate subdirectory of changelog.d
• Read and follow the PR guidelines

[stefanwire]

wire-server/services/galley/src/Galley/API/MLS/SubConversation.hs

Line 297 in 28fb371

let newGid = fromRight (convToGroupId' (flip SubConv scnvId <$> tUntagged lcnvId)) $ nextGenGroupId gid

should get extra attention during the review, since it swallows the error when creating a new group ID while deleting a subconversation.

[stefanwire]

wire-server/services/galley/test/integration/API.hs

Lines 3049 to 3066 in 7d72dca

	testAddRemoteMemberInvalidDomain :: TestM ()
	testAddRemoteMemberInvalidDomain = do
	alice <- randomUser
	bobId <- randomId
	let remoteBob = Qualified bobId (Domain "invalid.example.com")
	convId <- decodeConvId <$> postConv alice [] (Just "remote gossip") [] Nothing Nothing
	localDomain <- viewFederationDomain
	let qconvId = Qualified convId localDomain
	connectWithRemoteUser alice remoteBob
	postQualifiedMembers alice (remoteBob :| []) qconvId
	!!! do
	const 422 === statusCode
	const (Just "/federation/api-version")
	=== preview (ix "data" . ix "path") . responseJsonUnsafe @Value
	const (Just "invalid.example.com")
	=== preview (ix "data" . ix "domain") . responseJsonUnsafe @Value

has been removed, since it tests removed code.

wire-server/services/galley/test/integration/API.hs

Lines 3068 to 3087 in 7d72dca

	-- This test is a safeguard to ensure adding remote members will fail
	-- on environments where federation isn't configured (such as our production as of May 2021)
	testAddRemoteMemberFederationDisabled :: TestM ()
	testAddRemoteMemberFederationDisabled = do
	alice <- randomUser
	remoteBob <- flip Qualified (Domain "some-remote-backend.example.com") <$> randomId
	qconvId <- decodeQualifiedConvId <$> postConv alice [] (Just "remote gossip") [] Nothing Nothing
	connectWithRemoteUser alice remoteBob
	-- federator endpoint not configured is equivalent to federation being disabled
	-- This is the case on staging/production in May 2021.
	let federatorNotConfigured = optFederator .~ Nothing
	withSettingsOverrides federatorNotConfigured $
	postQualifiedMembers alice (remoteBob :| []) qconvId !!! do
	const 400 === statusCode
	const (Right "federation-not-enabled") === fmap label . responseJsonEither
	-- the member is not actually added to the conversation
	conv <- responseJsonError =<< getConvQualified alice qconvId <!! const 200 === statusCode
	liftIO $ map omQualifiedId (cmOthers (cnvMembers conv)) @?= []

has been removed, since it tests removed code.