[FS-1148] MLS-specific changes to adding members #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdimjasevic
force-pushed
the
fs-1148/only-for-mls
branch
from
1a1f559
to
3fed3be
Compare
zebot
added
the
ok-to-test
mdimjasevic
force-pushed
the
fs-1148/only-for-mls
branch
3 times, most recently
from
1ed472a
to
855953f
Compare
- Use FailedToProcess instead of Maybe UnreachableUsers
mdimjasevic
force-pushed
the
fs-1148/only-for-mls
branch
from
855953f
to
1a234b9
Compare
mdimjasevic
force-pushed
the
fs-1148/only-for-mls
branch
from
1a234b9
to
8f40d6b
Compare
mdimjasevic
force-pushed
the
fs-1148/only-for-mls
branch
2 times, most recently
from
33e9c96
to
1a6617c
Compare
In MLS a commit is rejected anyway so there is no point in passing through FailedToProcess. Instead, a federator error is thrown if there are unreachable backends when submitting an add commit.
mdimjasevic
force-pushed
the
fs-1148/only-for-mls
branch
from
1a6617c
to
baef2d1
Compare
- This is a bug to be fixed in the main MLS branch too
mdimjasevic
added a commit
that referenced
this pull request
May 29, 2023
mdimjasevic
added a commit
that referenced
this pull request
May 29, 2023
mdimjasevic
added a commit
that referenced
this pull request
May 29, 2023
mdimjasevic
added a commit
that referenced
this pull request
May 29, 2023
mdimjasevic
added a commit
that referenced
this pull request
May 29, 2023
mdimjasevic
added a commit
that referenced
this pull request
Jun 2, 2023
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to PR #3282. There are MLS-specific changes.
Given that an add commit cannot succeed partially, the response is not extended with a
failed_to_addfield like in the Proteus case. Instead, a 503 error is thrown in presence of unreachable backends/users. For more details see https://wearezeta.atlassian.net/wiki/spaces/CORE/pages/809763799/Offline+backend+handling+-+analysis+of+adding+participants+to+an+MLS+conversation.Tracked by https://wearezeta.atlassian.net/browse/FS-1148.
Checklist
changelog.d