Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLS migration feature config #3299

Merged
merged 7 commits into from
May 17, 2023
Merged

MLS migration feature config #3299

merged 7 commits into from
May 17, 2023

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented May 16, 2023 •
edited
Loading

New feature config for MLS migration.

https://wearezeta.atlassian.net/browse/FS-1581

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label May 16, 2023
@pcapriotti pcapriotti marked this pull request as ready for review May 16, 2023 11:40
rohan-wire
rohan-wire suggested changes May 16, 2023
View reviewed changes
Copy link
Contributor

@rohan-wire rohan-wire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a few changes to the defaults and in the examples.

It wasn't clear if hack/helm_vars/wire-server/values.yaml.gotml is part of an example or part of a test. If part of the test below, feel free to ignore the suggestion on that file.

charts/galley/values.yaml Outdated Show resolved Hide resolved
docs/src/understand/team-feature-settings.md Outdated Show resolved Hide resolved
hack/helm_vars/wire-server/values.yaml.gotmpl Outdated Show resolved Hide resolved
@pcapriotti pcapriotti merged commit 330cafa into mls May 17, 2023
@pcapriotti pcapriotti deleted the pcapriotti/mls-migration-config branch May 17, 2023 13:32
This was referenced Oct 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-wire rohan-wire rohan-wire requested changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcapriotti @rohan-wire @zebot