Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FS-1558] Add a test: delete a subconversation as a conversation member #3119

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Mar 2, 2023

This adds a test for deleting a subconversation where a user that is in the parent conversation, but not in the subconversation successfully deletes the subconversation. This is an important functionality that allows to delete a subconversation with members that have crashed and never cleaned it up.

Tracked by https://wearezeta.atlassian.net/browse/FS-1588.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@mdimjasevic mdimjasevic marked this pull request as ready for review March 2, 2023 16:43
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 2, 2023
@mdimjasevic mdimjasevic force-pushed the mdimjasevic/delete-subconv-as-conv-member branch from 66ddec5 to 978e027 Compare March 6, 2023 14:42
@mdimjasevic mdimjasevic force-pushed the mdimjasevic/delete-subconv-as-conv-member branch from 978e027 to 937b43a Compare March 7, 2023 11:05
@mdimjasevic mdimjasevic merged commit 0fcf0cb into mls Mar 7, 2023
@mdimjasevic mdimjasevic deleted the mdimjasevic/delete-subconv-as-conv-member branch March 7, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants