[FS-1488] Fix self-conversation creator key package mapping #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
mdimjasevic
force-pushed
the
mls-subconv-recreate-client-bug
branch
from
7c3b222
to
2b3257c
Compare
smatting
approved these changes
Feb 2, 2023
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in https://wearezeta.atlassian.net/browse/FS-1488, when a device of a creator of an MLS self-conversation is deleted, the device cannot be successfully removed from an MLS self-conversation. This was the case because there was no mapping of the creator client key package reference in Brig. This PR fixes that.
Checklist
changelog.d