Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FS-1335] Remove clients from subconversations when user is removed from main conversation #2942

Merged
merged 14 commits into from
Feb 15, 2023
Merged

[FS-1335] Remove clients from subconversations when user is removed from main conversation #2942

merged 14 commits into from
Feb 15, 2023

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Dec 20, 2022 •
edited by elland
Loading

https://wearezeta.atlassian.net/browse/FS-1335

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@elland elland changed the base branch from develop to mls December 20, 2022 10:12
@pcapriotti pcapriotti force-pushed the pcapriotti/subconv-parent-remove branch from 914a6fd to be11225 Compare January 9, 2023 09:12
@pcapriotti pcapriotti temporarily deployed to cachix January 9, 2023 09:12 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 9, 2023 09:12 — with GitHub Actions Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 9, 2023
@pcapriotti pcapriotti force-pushed the pcapriotti/subconv-parent-remove branch from e0bc201 to 9085b60 Compare January 9, 2023 11:05
@pcapriotti pcapriotti temporarily deployed to cachix January 9, 2023 11:05 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 9, 2023 11:05 — with GitHub Actions Inactive
@elland elland changed the title Remove clients from subconversations when user is removed from main conversation [FS-1335]: Remove clients from subconversations when user is removed from main conversation Jan 9, 2023
@elland elland changed the title [FS-1335]: Remove clients from subconversations when user is removed from main conversation [FS-1335] Remove clients from subconversations when user is removed from main conversation Jan 9, 2023
@elland elland temporarily deployed to cachix January 9, 2023 15:49 — with GitHub Actions Inactive
@elland elland temporarily deployed to cachix January 9, 2023 15:49 — with GitHub Actions Inactive
@elland elland force-pushed the pcapriotti/subconv-parent-remove branch from 52eee93 to 1892822 Compare January 12, 2023 11:09
@elland elland temporarily deployed to cachix January 12, 2023 11:10 — with GitHub Actions Inactive
@elland elland temporarily deployed to cachix January 12, 2023 11:10 — with GitHub Actions Inactive
@elland elland changed the base branch from mls to pcapriotti/subconv-leave January 12, 2023 11:10
@elland elland temporarily deployed to cachix January 12, 2023 12:30 — with GitHub Actions Inactive
@elland elland temporarily deployed to cachix January 12, 2023 12:30 — with GitHub Actions Inactive
@elland elland force-pushed the pcapriotti/subconv-parent-remove branch from 2f3ae62 to add911d Compare January 12, 2023 12:36
@elland elland temporarily deployed to cachix January 12, 2023 12:36 — with GitHub Actions Inactive
@elland elland temporarily deployed to cachix January 12, 2023 12:36 — with GitHub Actions Inactive
@pcapriotti pcapriotti force-pushed the pcapriotti/subconv-leave branch 2 times, most recently from a0e6ee3 to a54221c Compare January 16, 2023 10:17
@pcapriotti pcapriotti force-pushed the pcapriotti/subconv-leave branch 3 times, most recently from 40cffd3 to 167e8d4 Compare February 1, 2023 14:59
Base automatically changed from pcapriotti/subconv-leave to mls February 3, 2023 13:11
@smatting smatting force-pushed the pcapriotti/subconv-parent-remove branch 2 times, most recently from ebeae4a to 6d090ab Compare February 3, 2023 16:01
@elland elland force-pushed the pcapriotti/subconv-parent-remove branch from 086f57c to 90b95a0 Compare February 8, 2023 08:16
@elland elland force-pushed the pcapriotti/subconv-parent-remove branch from fb51e08 to 4f7a5e6 Compare February 8, 2023 08:51
@elland elland marked this pull request as ready for review February 8, 2023 08:53
stefanwire
stefanwire approved these changes Feb 13, 2023
View reviewed changes
libs/wire-api/src/Wire/API/Conversation.hs Outdated Show resolved Hide resolved
pcapriotti
pcapriotti commented Feb 13, 2023
View reviewed changes
Copy link
Contributor Author

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can't approve formally because it's my own PR.

@elland elland merged commit e1253d4 into mls Feb 15, 2023
@elland elland deleted the pcapriotti/subconv-parent-remove branch February 15, 2023 18:19
This was referenced Oct 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elland elland elland left review comments

@stefanwire stefanwire stefanwire approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcapriotti @elland @stefanwire @zebot