-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use locally built schema binaries for db migrations #2791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one small change request.
# For using stack see the Makefile of the package, e.g. services/brig/Makefile | ||
# Usage: make db-migrate-package package=galley | ||
.PHONY: db-migrate-package | ||
db-migrate-package: c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you keep a goal that juts emits a deprecation warning tell you what to call instead? (for both reset and migrate.)
646e3e7
to
0b3d170
Compare
Also make sure DB is up to date every time tests are run and not just when DBs are spun up.
0b3d170
to
1a36a2e
Compare
* Makefile: Allow db-migrate and db-reset to migrate/reset all keyspaces * Use locally built schema binaries for db migrations Also make sure DB is up to date every time tests are run and not just when DBs are spun up.
Also make sure DB is up to date every time tests are run and not just when DBs
are spun up.
This allows us to not rely on the "latest" tag of these docker images and also make spinning up local ephemeral services faster.