Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup to nixification: correctly load root CA TLS/SSL certificates in http(s) managers #2772

Merged
merged 7 commits into from
Oct 19, 2022
Merged

Fixup to nixification: correctly load root CA TLS/SSL certificates in http(s) managers #2772

merged 7 commits into from
Oct 19, 2022

Conversation

jschaul
Copy link
Member

@jschaul jschaul commented Oct 18, 2022 •
edited
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@jschaul jschaul temporarily deployed to cachix October 18, 2022 16:15 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 18, 2022
@akshaymankar akshaymankar temporarily deployed to cachix October 19, 2022 11:37 Inactive
@jschaul jschaul changed the title cacert-fixup attempt Fixup to nixification: correctly load root CA TLS/SSL certificates in http(s) managers Oct 19, 2022
@akshaymankar akshaymankar temporarily deployed to cachix October 19, 2022 11:39 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix October 19, 2022 12:36 Inactive
@jschaul jschaul temporarily deployed to cachix October 19, 2022 12:59 Inactive
@jschaul jschaul merged commit 341e58c into develop Oct 19, 2022
@jschaul jschaul deleted the cacert-fixup branch October 19, 2022 14:30
elland pushed a commit that referenced this pull request Oct 24, 2022
@jschaul @akshaymankar @elland
Fixup to nixification: correctly load root CA TLS/SSL certificates in…
f19cdde 
… http(s) managers (#2772)

* cacert-fixup attempt

* Use SSL.contextSetDefaultVerifyPaths so we respect SSL_CERT_FILE env var

* Revert "cacert-fixup attempt"

This reverts commit 398cec1.

No need.

* Set SSL_CERT_FILE in all docker images

* Changelog

* Redundant imports

* more redundant imports

Co-authored-by: Akshay Mankar <akshay@wire.com>
This was referenced Nov 2, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jschaul @akshaymankar @zebot