-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQSERVICES-1646] Servantify Gundeck #2769
Conversation
88aa43f
to
371f02a
Compare
371f02a
to
12610e6
Compare
f392135
to
d6eae9a
Compare
d6eae9a
to
d4f9920
Compare
d4f9920
to
86a2491
Compare
7efffae
to
50f891f
Compare
af76d6d
to
613bb56
Compare
ad6f324
to
045177e
Compare
Maybe ClientId -> | ||
Maybe (Range 100 10000 Int32) -> | ||
Gundeck (Maybe Public.QueuedNotificationList) | ||
paginate uid mbSince mbClient mbSize = do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a copy of services/gundeck/src/Gundeck/Notification.hs? do you want to remove the latter, than?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this question. The link seems to point to something unrelated.
most of my second batch of comments are nit-picks, and you have a green review, but i still have questions. :) if you want my ok, let's talk, but i trust stephen, you can also just merge. |
Broken during servantification: #2769
Broken during servantification: #2769
Broken during servantification: #2769
Broken during servantification: #2769
Broken during servantification: #2769
https://wearezeta.atlassian.net/browse/SQSERVICES-1646
Checklist
changelog.d