Polysemy: intersperse combinator #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elland
reviewed
Oct 17, 2022
elland
reviewed
Oct 17, 2022
Co-authored-by: Igor Ranieri Elland <54423+elland@users.noreply.github.com>
elland
approved these changes
Oct 24, 2022
elland
added a commit
that referenced
this pull request
Oct 24, 2022
* feat: implement intersperse and testing framework * chore: format * doc: changelog * test: add a test showing a simpler use of intersperse * chore: format * Update libs/polysemy-wire-zoo/test/Test/IntersperseSpec.hs Co-authored-by: Igor Ranieri Elland <54423+elland@users.noreply.github.com> * chore: disable hlint hint Co-authored-by: Igor Ranieri Elland <54423+elland@users.noreply.github.com>
mdimjasevic
reviewed
Oct 25, 2022
This was referenced Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new polysemy combinator
interspersewhich allows for injecting logic between every handled action in the effect stack. It also adds a test-suite topolysemy-wire-zoo, with a new test showing how to useintersperseto poll from anasyncthread.The short-term use case for this is to use it to test brig's STOMP client, where we can
interspersethe listener callback, which otherwise gets in the way of the removingIOeffort.Checklist
changelog.d