Servantify brig's auth API #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
smatting
force-pushed
the
pcapriotti/servantify-auth
branch
from
d44a6c5
to
00ed245
Compare
pcapriotti
force-pushed
the
pcapriotti/servantify-auth
branch
from
71abed8
to
63aa3de
Compare
pcapriotti
force-pushed
the
pcapriotti/servantify-auth
branch
from
464ef46
to
9ffac00
Compare
pcapriotti
force-pushed
the
pcapriotti/servantify-auth
branch
from
9ffac00
to
53ba06a
Compare
pcapriotti
force-pushed
the
pcapriotti/servantify-auth
branch
from
53ba06a
to
aedd79e
Compare
This reverts commit 165340a.
pcapriotti
force-pushed
the
pcapriotti/servantify-auth
branch
from
6670373
to
d218c43
Compare
elland
pushed a commit
that referenced
this pull request
Oct 24, 2022
* Servant Cookie combinator * Parse authorization header * Remove confusing type synonyms * Create schemas for Wire.API.User.Auth types * Fix build and golden tests * Add Access(..) * Add mkSomeAccess and mkSomeCookie & adapt * Optional response headers in MultiVerb * Replace SomeCookie with UserTokenCookie * Finish servantification of access endpoint * Servantify send-login-code * Servantify login endpoint * Servantify logout endpoint * Servantify change-self-email endpoint * Servantify list-cookies endpoint * Servantify remove-cookies endpoint * Change status code to 200 * Servantify legalhold-login endpoint * Servantify sso-login endpoint * Servantify login-code endpoint * Servantify reauthenticate endpoint * Fix build * Add access_token query parameter * Parse cookies leniently * Adapt integration test to new error codes * Add CanThrow annotations * Document Bearer token in Swagger * Add CHANGELOG entry * Revert "Adapt integration test to new error codes" This reverts commit 165340a. * Make servant cookie parser lenient * More leniency in Servant parsers * Adapt some tests * Remove redundant Brig error * Redundant brackets * lbl → label * Reformat long line * Remove empty routes * Apply hlint suggestions * Regenerate nix derivations Co-authored-by: Stefan Matting <stefan@wire.com>
This was referenced Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces servant combinators for cookies and the Authorization header, and converts all of brig's auth endpoints to servant.
Checklist
changelog.d