Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak wording in reference docs #2178

Merged
merged 3 commits into from
Mar 7, 2022
Merged

Tweak wording in reference docs #2178

merged 3 commits into from
Mar 7, 2022

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Mar 7, 2022 •
edited
Loading

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.

@fisx fisx requested a review from battermann March 7, 2022 08:33
pcapriotti
pcapriotti approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

One minor suggestion: instead of "it is the default", I would maybe write "the default is chosen".

fisx
fisx commented Mar 7, 2022
View reviewed changes
docs/reference/config-options.md Outdated Show resolved Hide resolved
@fisx fisx merged commit 075470f into develop Mar 7, 2022
@fisx fisx deleted the docs branch March 7, 2022 12:09
fisx added a commit that referenced this pull request Mar 7, 2022
@fisx
Tweak wording in reference docs (#2178)
7a66bae 
* Remove trailing whitespace.

* Tweak wording.

* Update docs/reference/config-options.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

@battermann battermann battermann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fisx @pcapriotti @battermann