Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add qualified broadcast endpoint #2166

Merged
merged 12 commits into from
Mar 3, 2022
Merged

Add qualified broadcast endpoint #2166

merged 12 commits into from
Mar 3, 2022

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Mar 1, 2022 •
edited
Loading

This adds a qualified version of the message broadcast endpoint, with the same API as the one for normal messages. This makes it possible for the clients to uniformly use the qualified API for all possible message types.

Tracked by https://wearezeta.atlassian.net/browse/SQCORE-1257.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If HTTP endpoint paths have been added or renamed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@atomrc atomrc mentioned this pull request Mar 1, 2022
Merged
3 tasks
mdimjasevic
mdimjasevic approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, but before merging please take a look at the comment on changing [(UserId, (ClientId, Text)] to [(UserId, ClientId, Text)].

deploy/services-demo/conf/nginz/nginx.conf Outdated Show resolved Hide resolved
services/galley/src/Galley/API/Update.hs Outdated Show resolved Hide resolved
services/galley/test/integration/API/Util.hs Show resolved Hide resolved
services/galley/test/integration/API/Teams.hs Outdated Show resolved Hide resolved
services/galley/test/integration/API/Teams.hs Outdated Show resolved Hide resolved
services/galley/test/integration/API/Teams.hs Outdated Show resolved Hide resolved
services/galley/test/integration/API/Teams.hs Outdated Show resolved Hide resolved
@pcapriotti pcapriotti merged commit a55abd7 into develop Mar 3, 2022
@pcapriotti pcapriotti deleted the pcapriotti/broadcast-qualified branch March 3, 2022 16:49
@zebot zebot mentioned this pull request Mar 7, 2022
Merged
fisx pushed a commit that referenced this pull request Mar 7, 2022
@pcapriotti @fisx
Add qualified broadcast endpoint (#2166)
17cd543 
* Add qualified broadcast endpoint

* Refactor broadcast tests

This uses a record to organise arguments for the helper function.

* Add qualified broadcast tests

* Fix mismatch assertions in broadcast tests

* Generalise broadcast route in nginz configuration

* Add release note entry

* Restore authentication for broadcast in demo nginz

* Remove redundant use of `runLocalInput`

* Rename broadcast tests
@zebot zebot mentioned this pull request Mar 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdimjasevic mdimjasevic mdimjasevic approved these changes

@akshaymankar akshaymankar Awaiting requested review from akshaymankar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcapriotti @mdimjasevic