Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of event record types #2160

Merged
merged 6 commits into from
Mar 3, 2022
Merged

Cleanup of event record types #2160

merged 6 commits into from
Mar 3, 2022

Conversation

pcapriotti
Copy link
Contributor

This PR removes the redundant type fields in both the conversation and team Event record types.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@pcapriotti pcapriotti requested a review from smatting March 2, 2022 10:32
@pcapriotti pcapriotti merged commit ad40381 into develop Mar 3, 2022
@pcapriotti pcapriotti deleted the pcapriotti/event-cleanup branch March 3, 2022 07:31
@zebot zebot mentioned this pull request Mar 7, 2022
Merged
fisx pushed a commit that referenced this pull request Mar 7, 2022
@pcapriotti @smatting @fisx
Cleanup of event record types (#2160)
ce924d6 
* Remove redundant field in Event type

* Remove redundant field in team Event type

* Remove redundant federation Event module

Co-authored-by: Stefan Matting <stefan@wire.com>
@zebot zebot mentioned this pull request Mar 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smatting smatting smatting approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcapriotti @smatting