Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up to /api-version changes #2159

Merged
merged 6 commits into from
Mar 7, 2022
Merged

Follow-up to /api-version changes #2159

merged 6 commits into from
Mar 7, 2022

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Feb 25, 2022 •
edited
Loading

  • Add test for additional api-version info
  • Comment about /access having to be unversioned, as requested here.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@pcapriotti pcapriotti marked this pull request as ready for review February 25, 2022 09:13
@pcapriotti pcapriotti requested a review from fisx March 1, 2022 13:37
@pcapriotti pcapriotti force-pushed the pcapriotti/api-version-tests branch from 43b1588 to eebe752 Compare March 2, 2022 13:07
@pcapriotti pcapriotti merged commit d6353af into develop Mar 7, 2022
@pcapriotti pcapriotti deleted the pcapriotti/api-version-tests branch March 7, 2022 10:32
@zebot zebot mentioned this pull request Mar 7, 2022
Merged
fisx pushed a commit that referenced this pull request Mar 7, 2022
@pcapriotti @fisx
Follow-up to /api-version changes (#2159)
63ec89f 
* Add test for additional api-version info

* Comment about /access having to be unversioned
@zebot zebot mentioned this pull request Mar 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdimjasevic mdimjasevic mdimjasevic approved these changes

@fisx fisx Awaiting requested review from fisx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcapriotti @mdimjasevic