wire-api-federation: Disconnect from federator after consuming the re…

…sponse (#3663)
wireapp · Oct 19, 2023 · 3aaa9f8 · 3aaa9f8
1 parent 4328659
commit 3aaa9f8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/changelog.d/3-bug-fixes/federator-disconnect b/changelog.d/3-bug-fixes/federator-disconnect
@@ -0,0 +1 @@
+Fix memory and TCP connection leak in brig, galley, caroghold and background-worker.
diff --git a/libs/wire-api-federation/src/Wire/API/Federation/Client.hs b/libs/wire-api-federation/src/Wire/API/Federation/Client.hs
@@ -126,7 +126,8 @@ withNewHttpRequest target req k = do
   sendReqMVar <- newEmptyMVar
   thread <- liftIO . async $ H2Manager.startPersistentHTTP2Connection ctx target cacheLimit sslRemoveTrailingDot tcpConnectionTimeout sendReqMVar
   let newConn = H2Manager.HTTP2Conn thread (putMVar sendReqMVar H2Manager.CloseConnection) sendReqMVar
-  H2Manager.sendRequestWithConnection newConn req k
+  H2Manager.sendRequestWithConnection newConn req $ \resp -> do
+    k resp <* newConn.disconnect
 
 performHTTP2Request ::
   Http2Manager ->