Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use our forks in DEPS, and restore FTP protocol handling. #511

Merged
merged 9 commits into from
May 12, 2024

Conversation

Alex313031
Copy link

To use these, delete the old directories, then run a git pull, and finally run gclient runhooks which will tell git from depot_tools to fetch these at the specified revision, rather than upstream's

@Alex313031
Copy link
Author

@win32ss I also sent you an invite in both of those repos to become a collaborator (committer)

@Alex313031 Alex313031 reopened this Apr 29, 2024
@win32ss
Copy link
Owner

win32ss commented Apr 29, 2024

I was waiting to make another Supermium release before accepting this PR, but for a few reasons this release has slipped. I hope to release it in the next few days and accept the PR.

@Alex313031
Copy link
Author

@win32ss I will re-invite you to those repos. Also, I could make a boringSSL repo too. That way we can use it here in DEPS, and so that it isn't just a collection of .zips but the actual source.

@win32ss
Copy link
Owner

win32ss commented May 1, 2024

@win32ss I will re-invite you to those repos. Also, I could make a boringSSL repo too. That way we can use it here in DEPS, and so that it isn't just a collection of .zips but the actual source.

The boringssl repo is currently deprecated because its only purpose was to remove a call to ProcessPrng. Now progwrp handles this as its signature is identical to RtlGenRandom/SystemFunction036.

@Alex313031
Copy link
Author

@win32ss OK, I still use the boringssl and webrtc patches since my win7 builds exclude progwrp entirely. I'll maintain those myself separately.

Anyway, I redid my invite for those two repos. You should accept it within 24 hours or it expires.

@Alex313031
Copy link
Author

@win32ss I didn't actually try it until now lol. I wanted to compare a Supermium compile to a Thorium compile to test for regressions, and so cloned by repo, and noticed some errors in DEPS. Anyway, it's all fixed, and this PR works properly now.

@Alex313031
Copy link
Author

Alex313031 commented May 12, 2024

@win32ss This PR has now been updated with another commit, which restores registering Chromium/Supermium/Thorium as a FTP protocol handler during installation. This was actually removed in M75, many versions before they completely removed FTP support entirely (M89). Their reasoning was "it isn't often used". Since the point of your recent FTP commits is to restore Chromium's FTP support back to the WinXP/Win7 era days, this is also good to have. I have tested it and it works fine. I could open an ftp:// url in an external app, and it would open Thorium to the correct page and display the file listing.

Note that you will have to add logic for this in your installer (and I will have to add it to my installer .bat files), since this only affects the mini_installer.

Speaking of which, when will you open source the GUI installer? My install scripts work well enough, but the problem is with the registry entries, which must be hard coded. This makes them not work right when people have their Windows installation on any drive letter other than "C:"

@Alex313031 Alex313031 changed the title Use our forks in DEPS and .gitmodules Use our forks in DEPS, and restore FTP protocol handling. May 12, 2024
@win32ss
Copy link
Owner

win32ss commented May 12, 2024

I recently added NVMe SSDs to the Supermium build system and successfully moved the main copy of the Supermium repository from an external USB HDD to one of the SSDs. Now that the process is complete, I will apply this PR.

I should be able to open up the installer in a few days.

@win32ss win32ss merged commit 04b170c into win32ss:main May 12, 2024
@Alex313031
Copy link
Author

Alex313031 commented May 12, 2024

@win32ss Does your installer work with drives other than C:?

For example, I use %PROGRAMFILES% to make sure it is always copied to the right location, but to make the registry entries that the mini_installer normally does, I am using .reg files that are hard coded.

Does your GUI installer make the .reg entries dynamically, and use the correct drive letter?

Also: I re-sent the invite in skia-supermium and pdfium-supermium. Expires in 24 hours. NVM, I saw you accepted the request.

@win32ss
Copy link
Owner

win32ss commented May 12, 2024

Does your GUI installer make the .reg entries dynamically, and use the correct drive letter?

Yes, the installer uses the standard win32 registry API and uses the path specified by the user to produce the registry entries pointing to the executable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants