Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using ggplot2 internal functions #39

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

teunbrand
Copy link
Contributor

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break ggfittext.

The culprit of this breakage is the use of the internal theta_rescale() and r_rescale() functions. While ggplot2 attempt to maintain a reasonably stable interface for it exported functions, it makes no such promises for internal functions. This PR copies (an approximation of) the old functions, which makes ggfittext independent of the changes in the new internal functions.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help ggfittext get out a fix if necessary.

@wilkox wilkox merged commit 6c76438 into wilkox:master Jan 31, 2024
4 of 5 checks passed
@wilkox
Copy link
Owner

wilkox commented Jan 31, 2024

Much appreciated @teunbrand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants