Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 12.5 Deprecation Warning (worker.terminate()) #43

Closed
Haidy777 opened this issue Jul 4, 2019 · 1 comment
Closed

Node 12.5 Deprecation Warning (worker.terminate()) #43

Haidy777 opened this issue Jul 4, 2019 · 1 comment

Comments

@Haidy777
Copy link
Contributor

Haidy777 commented Jul 4, 2019

Hello,

I've just started using this great library. Since 12.5. worker.terminate() throws a deprecation Warning, as it returns a Promise now (see nodejs/node#28021).

Correct me if I am wrong, but

this.workers[i].worker.terminate(() => {
should be the only position where this should be changed?

I'll try to submit a PR to change it.

@wilk wilk closed this as completed in 7a1295e Jul 17, 2019
wilk added a commit that referenced this issue Jul 17, 2019
closes #43 Nodejs 12 compatibility
@wilk
Copy link
Owner

wilk commented Jul 17, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants